Make frequency selection work at runtime, by providing a setRegion method #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thod. This increases the size of the compiled sketch by 160 bytes, but that seems like a reasonable price to pay for runtime configuration of the region. Without this, #define-ing a frequency in the sketch has no effect, because that same #define is not present when the library is compiled.
|
@Jon-Bright Could you please add to the example, showing how to use this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases the size of the compiled sketch by 160 bytes, but that seems like a reasonable price to pay for runtime configuration of the region. The previous method, #define-ing a frequency in the sketch, has no effect because that same #define is not present when the library is compiled.
This option is my preferred option to fix this, in contrast with the PR just sent.
This option maintains compatibility with all code that currently works by keeping the default as US902.